Revert "Allow KafkaRoller talk to controller directly (#10016)" from 0.45.x release #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1f1a16d. This commit caused Warning messages indicating that describeQuorum request was sent to a non active controller therefore failed rolling a controller-only node. We discovered that non active controller does not forward the request to the active controller like broker does, but returns NOT_LEADER_OR_FOLLOWER error. This issue gets resolved by itself eventually after retrying the request several times, because the describeQuorum gets sent to the active controller at some point. However, it could cause some delay in rolling controller-only nodes, due to the number of retrying. Reverting this commit from 0.45.0 release branch, and the issue will be fixed properly in the main branch to target the next release. Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
revert-roller-change
branch
from
054a39e to
dbdb29d
Compare
tinaselenge
changed the title
scholzj
approved these changes
Dec 12, 2024
|
/azp run regression |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
This reverts commit 1f1a16d.
This commit caused Warning messages indicating that describeQuorum request was sent to a non active controller therefore failed rolling a controller-only node. We discovered that non active controller does not forward the request to the active controller like broker does, but returns NOT_LEADER_OR_FOLLOWER error. This issue gets resolved by itself eventually after retrying the request several times, because the describeQuorum gets sent to the active controller at some point. However, it could cause some delay in rolling controller-only nodes, due to the number of retrying.
Reverting this commit from 0.45.0 release branch, and the issue will be fixed properly in the main branch to target the next release.
Checklist
Please go through this checklist and make sure all applicable tasks have been done