STPShippingAddressViewController does not use billing address if instrument is not an STPCard

[karlr-stripe]

Summary

The Shipping view controller has a button "Use billing" that will copy the billing address of a card, to avoid the user needing to enter that information twice when e.g. going through the flow of using the STPPaymentContext to complete a payment. For example, with

STPPaymentConfiguration.shared().requiredShippingAddressFields = [.postalAddress]
STPPaymentConfiguration.shared().requiredBillingAddressFields = STPBillingAddressFields.full

However, it looks like this only works if using Card objects, and not Source(or PaymentMethods):

stripe-ios/Stripe/STPShippingAddressViewController.m

Lines 51 to 56 in 1c5505f

	STPAddress *billingAddress = nil;
	id<STPPaymentOption> paymentOption = paymentContext.selectedPaymentOption;
	if ([paymentOption isKindOfClass:[STPCard class]]) {
	STPCard *card = (STPCard *)paymentOption;
	billingAddress = [card address];
	}

If you're not using Cards, then the option won't appear, which makes it less convenient for customers to check out.

Code to reproduce

STPPaymentConfiguration.shared().requiredShippingAddressFields = [.postalAddress]
STPPaymentConfiguration.shared().requiredBillingAddressFields = STPBillingAddressFields.full
STPPaymentConfiguration.shared().createCardSources = true

and integrate the STPPaymentContext.

iOS version

11.4

Installation method

Carthage

SDK version

15.0.1

Other information

[yuki-stripe]

@karlr-stripe Thanks for filing - tracking internally here https://jira.corp.stripe.com/browse/IOS-1278

[yuki-stripe]

Fixed in #1278