STPAddress <-> STPPaymentMethod #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STPShippingAddressViewController prefills PaymentMethod billing address
|
Made some minor fixes |
davidme-stripe
approved these changes
Aug 9, 2019
davidme-stripe
added a commit
that referenced
this pull request
Aug 13, 2019
This reverts commit ee3cc60.
wooj-stripe
pushed a commit
that referenced
this pull request
Jul 5, 2022
* Replace PhoneNumberElement * Copy over autofill hack * Delete PhoneNumberElement * Remove V2 in PhoneNumberElementV2 * Undo floating placeholder * Undo floating placeholder view * Support E164 default phone number behavior * Fix test * Fix test * Update localizable.strings * Fix tests * Update snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPAddressinitializable withSTPPaymentMethodBillingDetailsSTPUserInformationwithSTPPaymentMethodBillingDetailsSTPShippingAddressViewControllerprefills billing address for PaymentMethods too now, not just Card.Motivation
https://jira.corp.stripe.com/browse/IOS-1278
https://jira.corp.stripe.com/browse/IOS-1266
Testing