Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only card brand can be changed label #4336

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

joyceqin-stripe
Copy link
Collaborator

Summary

Added conditionally rendered footnote label for cobranded choice card

Motivation

Testing

Changelog

Copy link

github-actions bot commented Dec 5, 2024

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Only card brand can be changed.

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@joyceqin-stripe joyceqin-stripe marked this pull request as ready for review December 5, 2024 23:42
@joyceqin-stripe joyceqin-stripe requested review from a team as code owners December 5, 2024 23:42
@joyceqin-stripe joyceqin-stripe enabled auto-merge (squash) December 6, 2024 16:32
@joyceqin-stripe joyceqin-stripe merged commit 060909e into master Dec 9, 2024
7 checks passed
@joyceqin-stripe joyceqin-stripe deleted the joyceqin-only-card-brand-can-be-changed branch December 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants