Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only card brand can be changed label #4336

Merged
merged 4 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,9 @@ re-entering the security code (CVV/CVC). */
/* Text of a label for confirming an email address. E.g., 'Not [email protected]?' */
"Not %@?" = "Not %@?";

/* Text on a screen for updating a cobranded card that indicates only card brand can be changed. */
"Only card brand can be changed." = "Only card brand can be changed.";

/* Countdown timer text on a screen asking the user to approve a payment */
"Open your UPI app to approve your payment within %@" = "Open your UPI app to approve your payment within %@";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ extension String.Localized {
)
}

static var only_card_brand_can_be_changed: String {
STPLocalizedString(
"Only card brand can be changed.",
"Text on a screen for updating a cobranded card that indicates only card brand can be changed."
)
}

static var save: String {
STPLocalizedString(
"Save",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ final class UpdatePaymentMethodViewController: UIViewController {
}()

private lazy var footnoteLabel: UITextView? = {
if viewModel.canEdit || viewModel.errorState {
if viewModel.errorState {
return nil
}
let label = ElementsUI.makeSmallFootnote(theme: viewModel.appearance.asElementsTheme)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class UpdatePaymentMethodViewModel {
lazy var footnote: String = {
switch paymentMethod.type {
case .card:
return .Localized.card_details_cannot_be_changed
return canEdit ? .Localized.only_card_brand_can_be_changed : .Localized.card_details_cannot_be_changed
case .USBankAccount:
return .Localized.bank_account_details_cannot_be_changed
case .SEPADebit:
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ControllerSnapshotTests/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ewControllerSnapshotTests/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...wControllerSnapshotTests/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading