Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add light mode/dark mode switcher #1006

Closed
lorypelli opened this issue Apr 21, 2023 · 7 comments · Fixed by #1015
Closed

Add light mode/dark mode switcher #1006

lorypelli opened this issue Apr 21, 2023 · 7 comments · Fixed by #1015
Labels
enhancement New feature or request

Comments

@lorypelli
Copy link

I hate light mode
@styfle styfle added the enhancement New feature or request label Apr 21, 2023
@styfle
Copy link
Owner

styfle commented Apr 21, 2023 •
edited
Loading

PR is welcome 👍

Ideally it should use the system theme, no manual switch needed.

@ali963sy

This comment was marked as outdated.

Sign in to view
@lorypelli

This comment was marked as outdated.

Sign in to view
@ali963sy

This comment was marked as spam.

Sign in to view
@MathurAditya724
Copy link
Contributor

Hey can I work on the PR, and also can I use tailwindcss for this?

@styfle
Copy link
Owner

styfle commented Oct 12, 2023

You can work on it but not with tailwind.

In the future, we can choose to switch to tailwind but today it could be implemented with a separate stylesheet.

@MathurAditya724
Copy link
Contributor

Okay sure

@MathurAditya724 MathurAditya724 mentioned this issue Oct 28, 2023
Merged
3 tasks
@styfle styfle linked a pull request Oct 29, 2023 that will close this issue
Added Support for Dark Mode 🌙 #1015
Merged
3 tasks
styfle added a commit that referenced this issue Nov 1, 2023
@MathurAditya724 @styfle
Added Support for Dark Mode 🌙 (#1015)
0169964 
Issue - #1006 

- [x] Added CSS Variables for managing the colors
- [x] Changes mode based on the user's color preference

I have changed the color scheme according to my taste. Feel free to
change it or let me know if any more changes are required.

---------

Co-authored-by: Steven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Support for Dark Mode 🌙
4 participants
@styfle @MathurAditya724 @lorypelli @ali963sy