-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Dark Mode ๐ #1015
Conversation
@MathurAditya724 is attempting to deploy a commit to the Package Phobia Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
src/components/SearchBar.tsx
Outdated
@@ -12,14 +12,15 @@ const height = '4rem'; | |||
const radius = '3px'; | |||
|
|||
const input: React.CSSProperties = { | |||
color: '#333', | |||
color: 'var(--muted-foreground)', | |||
background: 'var(--muted)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change it to use something like this design:
I have made all the requested changes, please have a look |
@MathurAditya724 I'm still seeing the dark gray input instead of white. Also the search icon is hard to see. https://packagephobia-git-fork-mathuraditya724-main-packagephobia.vercel.app/result?p=satori Can you ensure that the light mode colors are not changed from the original here: |
Some silly mistake on my end ๐ , please have a look |
All good? |
@MathurAditya724 Light mode looks good now ๐ However, dark mode has the colors flipped in the bar chart. Can we keep the darker shade of green on the bottom? |
This commit should resolve this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! ๐
@styfle just wondering, wouldn't it make more sense if the new CSS file was inlined too? |
I'm starting to think inlining is not the right solution since it can't be cached between page navigations. |
That makes sense too, as long as you move all CSS to an external site. That being said, you need cache busting along with proper cache headers, and preload if you don't want to use a blocking CSS. Your call, I just noticed the inconsistency and it's easier to just inline the newly added selectors like the rest. |
Issue - #1006
I have changed the color scheme according to my taste. Feel free to change it or let me know if any more changes are required.