Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #9

Closed
2 tasks
jeddy3 opened this issue Feb 9, 2023 · 0 comments · Fixed by #12
Closed
2 tasks

Improve test coverage #9

jeddy3 opened this issue Feb 9, 2023 · 0 comments · Fixed by #12
Labels
status: ask to implement ask before implementing as may no longer be relevant

Comments

@jeddy3
Copy link
Member

jeddy3 commented Feb 9, 2023

  • happy path
  • failure during installation (I think I'll have to mock execa for this)

Ref: #1 (comment)
@jeddy3 jeddy3 added status: ask to implement ask before implementing as may no longer be relevant type: tests labels Feb 9, 2023
@mattxwang mattxwang mentioned this issue Feb 12, 2023
Merged
mattxwang added a commit that referenced this issue Feb 14, 2023
@mattxwang @ybiquitous
Improve test coverage (happy path, npm failure) (#12)
52dbc0a 
Closes #9.

The happy path test is a bit unorthodox in that it actually does run `npm install`. I think it would be better to do this with a dry run, but currently there's no way for me to pass that argument in to `npm`; I can implement a dry-run feature for stylelint-create after this PR.

---------

Co-authored-by: Masafumi Koba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ask to implement ask before implementing as may no longer be relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve test coverage (happy path, npm failure) stylelint/create-stylelint
1 participant
@jeddy3