Use send_email wrapper to apply subject with server name when not prod #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreben
commented
Nov 5, 2024
There was a problem hiding this comment.
@jermnelson Maybe you can help figure out why the test fail for this test file?
There was a problem hiding this comment.
When patching "libsys_airflow.plugins.digital_bookplates.email.send_email_with_server_name" it never calls the wrapper function when running the test, and so the test fails the assertion. If you change the patch to "libsys_airflow.plugins.shared.utils.send_email_with_server_name" it calls the wrapper function, but then it tries to send a real email and does not actually patch send_email.
jgreben
force-pushed
the
1131-email-with-server-name
branch
from
ecb7dcc to
998aab6
Compare
jermnelson
approved these changes
Nov 6, 2024
shelleydoljack
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131