Generate Multiple OCLC Numbers Report with Link in Email

[jermnelson]

Fixes #1194

[jgreben]

@jermnelson can you take a look at #1407 before we merge this?

[jgreben]

Question about task group calling task that calls a single function. Also, it may be easier for you to rebase this off of #1407 if we can sort out the test on that?

[jermnelson]

@jermnelson can you take a look at #1407 before we merge this?

I made this PR a draft until #1407 is approved and merged and then I'll rebase off of main then.

[shelleydoljack]

I checked the email that was sent and the report looks good except the link to the DAG Run doesn't work. The error is DAG "13306" seems to be missing from DagBag.. Is 13306 the dag_id? Maybe the link should be https://sul-libsys-airflow-dev.stanford.edu/dags/select_oclc_records/grid?dag_run_id=manual__2024-11-07T00%3A42%3A19.037638%2B00%3A00 instead?

[jermnelson]

I checked the email that was sent and the report looks good except the link to the DAG Run doesn't work. The error is DAG "13306" seems to be missing from DagBag.. Is 13306 the dag_id? Maybe the link should be https://sul-libsys-airflow-dev.stanford.edu/dags/select_oclc_records/grid?dag_run_id=manual__2024-11-07T00%3A42%3A19.037638%2B00%3A00 instead?

This PR just uses the existing function dag_run_url that sets the DAG run URL here:

libsys-airflow/libsys_airflow/plugins/data_exports/email.py

Line 95 in dd9f90a

return f"{airflow_url}dags/{dag_run.id}/grid?{params}"

.

Emails and the OCLC reports use this function so it is strange this bug hasn't been noted before. I can create a bug ticket but it more general than this PR.

[shelleydoljack]

I checked the email that was sent and the report looks good except the link to the DAG Run doesn't work. The error is DAG "13306" seems to be missing from DagBag.. Is 13306 the dag_id? Maybe the link should be https://sul-libsys-airflow-dev.stanford.edu/dags/select_oclc_records/grid?dag_run_id=manual__2024-11-07T00%3A42%3A19.037638%2B00%3A00 instead?

This PR just uses the existing function dag_run_url that sets the DAG run URL here:

libsys-airflow/libsys_airflow/plugins/data_exports/email.py

Line 95 in dd9f90a

return f"{airflow_url}dags/{dag_run.id}/grid?{params}"

.
Emails and the OCLC reports use this function so it is strange this bug hasn't been noted before. I can create a bug ticket but it more general than this PR.

I am now just realizing that it was noticed before when the POD transmission failed (which it did last night again). The link https://sul-libsys-airflow-prod.stanford.edu/dags/86302/grid?dag_run_id=scheduled__2024-11-06T08%3A00%3A00%2B00%3A00 goes to the missing dagbag error message. Yes, maybe a follow-on PR. I think maybe dag_run.id != dag_run.dag_id 🤷