Implement CacheLifetimeBehaviourInterface in ArticleBridge #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-rath
force-pushed
the
feature/cache-lifetime-behaviour
branch
from
46dc671 to
7cbe015
Compare
|
|
nope, therefore I added the fallback interface here |
Co-authored-by: Alexander Schranz <[email protected]>
alexander-schranz
approved these changes
Sep 20, 2022
luca-rath
commented
Sep 20, 2022
alexander-schranz
requested changes
Sep 20, 2022
luca-rath
commented
Sep 20, 2022
Co-authored-by: Alexander Schranz <[email protected]>
|
The php-cs fixer fails we did fix this issue by adopting the php-cs fixer config in our projects to this: 'phpdoc_to_comment' => [
'ignored_tags' => ['todo', 'var', 'see', 'phpstan-ignore-next-line'],
], |
alexander-schranz
approved these changes
Sep 20, 2022
wachterjohannes
pushed a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Implement CacheLifetimeBehaviourInterface in ArticleBridge
Why?
This allows Sulu's
CacheLifetimeEnhancerservice to work withArticleBridgeobjects. The reason for this is, that theHeadlessWebsiteControllercan then be used to render articles.