Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CacheLifetimeBehaviourInterface in ArticleBridge #621

Merged
merged 8 commits into from
Sep 20, 2022
Merged

Implement CacheLifetimeBehaviourInterface in ArticleBridge #621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a2a5c8
Implement CacheLifetimeBehaviourInterface in ArticleBridge
luca-rath Sep 14, 2022
7cbe015
Fix phpstan issue
luca-rath Sep 14, 2022
39671f2
Rename CacheLifetimeBehaviourInterface to RoutableStructureInterface
luca-rath Sep 20, 2022
f0462fb
Update Document/Structure/RoutableStructureInterface.php
luca-rath Sep 20, 2022
40cc73b
Fix phpstan
luca-rath Sep 20, 2022
bc497de
Apply suggestions from code review
luca-rath Sep 20, 2022
71f4d0c
Apply suggestions from code review
luca-rath Sep 20, 2022
4935506
Fix php-cs
luca-rath Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Document/Structure/ArticleBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,26 @@ class ArticleBridge extends StructureBridge implements RoutableStructureInterfac

public function getView(): string
{
return $this->structure->getView();
/** @var string $view */
$view = $this->structure->getView();

return $view;
luca-rath marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* @return string
*/
public function getController()
{
return $this->structure->getController();
/** @var string $controller */
$controller = $this->structure->getController();

return $controller;
luca-rath marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* @return array{type: string, value: string}
*/
public function getCacheLifeTime()
luca-rath marked this conversation as resolved.
Show resolved Hide resolved
{
/** @var array{type: string, value: string} $cacheLifetime */
Expand Down
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,11 +1525,6 @@ parameters:
count: 1
path: Document/Structure/ArticleBridge.php

-
message: "#^Method Sulu\\\\Bundle\\\\ArticleBundle\\\\Document\\\\Structure\\\\ArticleBridge\\:\\:getView\\(\\) should return string but returns string\\|null\\.$#"
count: 1
path: Document/Structure/ArticleBridge.php

-
message: "#^Method Sulu\\\\Bundle\\\\ArticleBundle\\\\Document\\\\Structure\\\\ArticleBridge\\:\\:setUuid\\(\\) has no return type specified\\.$#"
count: 1
Expand Down