This repository has been archived by the owner on Sep 23, 2020. It is now read-only.
Added recursive restore to allow also versions of children #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/child-versions
branch
4 times, most recently
from
c385e37 to
37d84a2
Compare
wachterjohannes
force-pushed
the
feature/child-versions
branch
from
37d84a2 to
267c328
Compare
3 tasks
wachterjohannes
force-pushed
the
feature/child-versions
branch
from
267c328 to
4d0779c
Compare
wachterjohannes
force-pushed
the
feature/child-versions
branch
from
4d0779c to
ed6bacb
Compare
danrot
suggested changes
Apr 18, 2017
| ); | ||
| } | ||
|
|
||
| // remove child-nodes which does not exists in frozen-node |
There was a problem hiding this comment.
which do not exist in frozen node
| @@ -343,6 +345,7 @@ public function testRestoreLocalizedProperties() | |||
| $property3 = $this->prophesize(PropertyInterface::class); | |||
| $property3->getName()->willReturn('jcr:uuid'); | |||
| $node->getProperties()->willReturn([$property1->reveal(), $property2->reveal(), $property3->reveal()]); | |||
| $node->getNodes()->willReturn([]); | |||
There was a problem hiding this comment.
Please add also a test where the node has children, which should not be copied (as it is the case with the pages).
|
@danrot fixed |
danrot
suggested changes
Apr 19, 2017
| $versionHistory->getVersion('1.0')->willReturn($version->reveal()); | ||
| $version->getFrozenNode()->willReturn($frozenNode->reveal()); | ||
|
|
||
| $this->versionSubscriber->restoreProperties($event->reveal()); |
There was a problem hiding this comment.
There's not a single assertion in this test, so we cannot be sure that the child node has not been touched...
There was a problem hiding this comment.
it's not explicit but we could. every not mocked method call would let this test fail - but i will add some assertions.
wachterjohannes
force-pushed
the
feature/child-versions
branch
from
765b41c to
0b55bf6
Compare
wachterjohannes
commented
Apr 19, 2017
| $versionHistory->getVersion('1.0')->willReturn($version->reveal()); | ||
| $version->getFrozenNode()->willReturn($frozenNode->reveal()); | ||
|
|
||
| // the child-node should not be touched |
There was a problem hiding this comment.
@danrot i have added assertions
danrot
approved these changes
Apr 19, 2017
This was referenced Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
VersionSubscriberto allow also restore children.Requires jackalope/jackalope ^1.2.8