Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed versioning and remove-draft of article-pages #145

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Apr 18, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs build on top #122, requires sulu/sulu-document-manager#108 and jackalope/jackalope ^1.2.8
License MIT
Documentation PR none

What's in this PR?

This PR fixes versioning and drafting of removed / added article-pages.

To Do

  • Tests
  • PR in sulu/document-manager
  • Compatability of jacklope/jackalope 1.2.8

@wachterjohannes wachterjohannes force-pushed the feature/multi-page-versioning branch 2 times, most recently from 2d130cf to c5d6205 Compare April 18, 2017 08:11
@alexander-schranz
Copy link
Member

do we need to add jackalope 1.2.8 as minimum requirement?

@wachterjohannes wachterjohannes force-pushed the feature/multi-page-versioning branch from 7e03652 to 6718d8c Compare April 20, 2017 08:06
@wachterjohannes wachterjohannes force-pushed the feature/multi-page branch 2 times, most recently from c1210c1 to 3e016b1 Compare April 20, 2017 09:28
@wachterjohannes wachterjohannes force-pushed the feature/multi-page-versioning branch from 6718d8c to 391101a Compare April 20, 2017 09:55
@wachterjohannes wachterjohannes force-pushed the feature/multi-page-versioning branch from 391101a to f6f4b23 Compare April 20, 2017 09:57
@alexander-schranz alexander-schranz merged commit fd51fa9 into sulu:feature/multi-page Apr 20, 2017
@wachterjohannes wachterjohannes deleted the feature/multi-page-versioning branch April 20, 2017 10:42
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 21, 2017
* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 24, 2017
* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 25, 2017
* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 25, 2017
* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope
alexander-schranz pushed a commit that referenced this pull request Apr 25, 2017
* Implemented page document and API (#114)

* implemented basic page document

* added index pages to article

* fixed serialization context of article and article-page (#118)

* Add interface to manage article-pages (#116)

* introduced css grunt job

* added article-router

* added page dropdown

* added logic to create and update pages

* renamed adapter

* Added article title to page form (#123)

* added article title

* fixed selector for css stye

* fixed jquery selector of grid-row

* added page to content-navigation (#125)

* Fixed create article from ghost (#126)

* fixed create article from ghost

* hide new page link for new articls

* fixed code style

* added delete page button (#132)

* added translations (#128)

* added route-behavior to article-page (#131)

* Fixed priorities of subscriber (#137)

* fixed priorities of subscriber

* added tag to find routePath property

* Fixed title property (article-title) and add page title property (#141)

* fixed title property (article-title) and add page title property

* added node-name-slugifier

* Changed generating route only on publish (#138)

* use publish event to generate routes

* refactored because of sulu changes

* Added page-number argument to website-article-controller (#142)

* added serialization of pages

* added pages data to article-document

* fixed comments

* Added synchronize children between draft and live (#139)

* added synchronice children between draft and live

* fixed preview for new pages

* fixed serialization for preview

* fixed testcases

* Fixed versioning and remove-draft of article-pages (#145)

* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope

* implemented duplicate article (#146)

* Fixed preview-serialization of article pages (#154)

* fixed preview-serialization of article pages

* change view of renderArticle

* fixed type change on list (#156)

* Fixed metadata for article to sync remove (#155)

* fixed metadata for article

* fixed routable-subscriber to remove all routes (locales)

* removed article-page copy locale (#157)

* fixed code-style

* fixed test-setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants