Add upgrade for rename getUsername to getUserIdentifier

[alexander-schranz]

This will already rename the sulu users getUsername to getUserIdentifier.

Try out this PR by copy following in your unix shell:

Upgrade for: sulu/sulu#6626

git clone [email protected]:sulu/sulu-rector.git
cd sulu-rector/
git remote add alex [email protected]:alexander-schranz/sulu-rector.git
git fetch alex
git checkout feature/replace-user-name-with-user-identifier-method
composer install
composer test

[alexander-schranz]

I don't get why this is failing in the CI 🤔 it seems to work correctly locally.

[alexander-schranz]

@TomasVotruba Sorry for pinging you but I'm little bit lost again. Do you have any hint what is going wrong here? It works locally for me:

git clone [email protected]:sulu/sulu-rector.git
cd sulu-rector/
git remote add alex [email protected]:alexander-schranz/sulu-rector.git
git fetch alex
git checkout feature/replace-user-name-with-user-identifier-method
composer install
composer test

but the rule just don't work in the CI which is very strange. Even checked if the CI installs other dependencies but they are the same. Also did cat the files the looks also correclty in the CI not sure what is going wrong here. Even updated the composer install actions still the rule test does not work in the CI.

[TomasVotruba]

I've just tested for a while locally to find this fix: rectorphp/rector-src@cbebb9a

Basically this rename would break parent interface contract. Untill the Symfony require parent interface, the method rename would cause a BC break:

public function getUsername();

Yet, in this case, the change could be done in an interface 👍 I'll see if we can improve it

[TomasVotruba]

This should help: rectorphp/rector-src#2362

Could you try rector dev-main?

[TomasVotruba]

See #8