Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade for rename getUsername to getUserIdentifier #8

Merged

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented May 25, 2022

This will already rename the sulu users getUsername to getUserIdentifier.

Upgrade for: sulu/sulu#6626

@alexander-schranz alexander-schranz merged commit c6bd3af into main May 27, 2022
@alexander-schranz alexander-schranz deleted the feature/replace-user-name-with-user-identifier-method branch May 27, 2022 08:27
@alexander-schranz
Copy link
Member

@TomasVotruba Thank you 🙏 really strange it did work locally for me but not in the CI 🤔

@alexander-schranz alexander-schranz added the feature A new upgrade rule label May 27, 2022
@TomasVotruba
Copy link
Contributor Author

@alexander-schranz You're welcome 👍
I think that's because of different Rector version. If you can, always use the latest Rector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new upgrade rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants