Skip to content

Commit

Permalink
Fix typos in the theme prop type (#933)
Browse files Browse the repository at this point in the history
  • Loading branch information
connor-baer authored May 14, 2021
1 parent 4660f11 commit e4c940b
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 16 deletions.
5 changes: 5 additions & 0 deletions .changeset/pretty-crews-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sumup/design-tokens': patch
---

Fixed two typos in the theme prop type: `theme.breakpoint``theme.breakpoints` and `theme.mx``theme.mq`.
49 changes: 33 additions & 16 deletions packages/design-tokens/utils/theme-prop-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,27 @@

import PropTypes from 'prop-types';

import {
Theme,
Typography,
Colors,
Spacings,
IconSizes,
BorderRadius,
BorderWidth,
FontStack,
FontWeight,
Breakpoints,
MediaQueries,
Grid,
Transitions,
ZIndex,
} from '../types';

const typePropType = PropTypes.shape({
fontSize: PropTypes.string,
lineHeight: PropTypes.string,
}).isRequired;
} as { [key in keyof Typography]: any }).isRequired;

const breakpointPropType = PropTypes.oneOfType([
PropTypes.string,
Expand Down Expand Up @@ -111,7 +128,7 @@ export const themePropType = PropTypes.shape({
shadow: PropTypes.string.isRequired,
bodyBg: PropTypes.string.isRequired,
bodyColor: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof Colors]: any }).isRequired,
spacings: PropTypes.shape({
bit: PropTypes.string.isRequired,
byte: PropTypes.string.isRequired,
Expand All @@ -122,24 +139,24 @@ export const themePropType = PropTypes.shape({
peta: PropTypes.string.isRequired,
exa: PropTypes.string.isRequired,
zetta: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof Spacings]: any }).isRequired,
iconSizes: PropTypes.shape({
kilo: PropTypes.string.isRequired,
mega: PropTypes.string.isRequired,
giga: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof IconSizes]: any }).isRequired,
borderRadius: PropTypes.shape({
kilo: PropTypes.string.isRequired,
mega: PropTypes.string.isRequired,
giga: PropTypes.string.isRequired,
tera: PropTypes.string.isRequired,
circle: PropTypes.string.isRequired,
pill: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof BorderRadius]: any }).isRequired,
borderWidth: PropTypes.shape({
kilo: PropTypes.string.isRequired,
mega: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof BorderWidth]: any }).isRequired,
typography: PropTypes.shape({
headings: PropTypes.shape({
kilo: typePropType,
Expand All @@ -163,12 +180,12 @@ export const themePropType = PropTypes.shape({
fontStack: PropTypes.shape({
default: PropTypes.string,
mono: PropTypes.string,
}).isRequired,
} as { [key in keyof FontStack]: any }).isRequired,
fontWeight: PropTypes.shape({
regular: PropTypes.string.isRequired,
bold: PropTypes.string.isRequired,
}).isRequired,
breakpoint: PropTypes.shape({
} as { [key in keyof FontWeight]: any }).isRequired,
breakpoints: PropTypes.shape({
untilKilo: breakpointPropType,
kilo: breakpointPropType,
kiloToMega: breakpointPropType,
Expand All @@ -178,8 +195,8 @@ export const themePropType = PropTypes.shape({
giga: breakpointPropType,
gigaToTera: breakpointPropType,
tera: breakpointPropType,
}).isRequired,
mx: PropTypes.shape({
} as { [key in keyof Breakpoints]: any }).isRequired,
mq: PropTypes.shape({
untilKilo: PropTypes.string.isRequired,
kilo: PropTypes.string.isRequired,
kiloToMega: PropTypes.string.isRequired,
Expand All @@ -189,19 +206,19 @@ export const themePropType = PropTypes.shape({
giga: PropTypes.string.isRequired,
gigaToTera: PropTypes.string.isRequired,
tera: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof MediaQueries]: any }).isRequired,
grid: PropTypes.shape({
default: gridPropType,
untilKilo: gridPropType,
kilo: gridPropType,
mega: gridPropType,
giga: gridPropType,
tera: gridPropType,
}).isRequired,
} as { [key in keyof Grid]: any }).isRequired,
transitions: PropTypes.shape({
default: PropTypes.string.isRequired,
slow: PropTypes.string.isRequired,
}).isRequired,
} as { [key in keyof Transitions]: any }).isRequired,
zIndex: PropTypes.shape({
default: PropTypes.number.isRequired,
absolute: PropTypes.number.isRequired,
Expand All @@ -215,5 +232,5 @@ export const themePropType = PropTypes.shape({
backdrop: PropTypes.number.isRequired,
sidebar: PropTypes.number.isRequired,
modal: PropTypes.number.isRequired,
}).isRequired,
});
} as { [key in keyof ZIndex]: any }).isRequired,
} as { [key in keyof Theme]: any });

1 comment on commit e4c940b

@vercel
Copy link

@vercel vercel bot commented on e4c940b May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.