Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the theme prop type #933

Merged
merged 2 commits into from
May 14, 2021
Merged

Fix typos in the theme prop type #933

merged 2 commits into from
May 14, 2021

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented May 13, 2021

Purpose

While working on the dashboard, I noticed peculiar prop-type warnings from the themePropType. Turns out they were typos πŸ™ˆ

Approach and changes

  • Fixed the typos: theme.breakpoint β†’ theme.breakpoints and theme.mx β†’ theme.mq
  • Added types to the prop-types so TypeScript will warn about typos in the future

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label May 13, 2021
@connor-baer connor-baer requested a review from robinmetral May 13, 2021 14:42
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2021

πŸ¦‹ Changeset detected

Latest commit: 0045e2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/design-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/sumup/oss-circuit-ui/6v14BSmvdedPw7D42d7gJtjhNx1h
βœ… Preview: https://oss-circuit-ui-git-bugfix-theme-prop-type-sumup.vercel.app

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #933 (0045e2e) into main (4660f11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         161      161           
  Lines        2916     2916           
  Branches      727      727           
=======================================
  Hits         2679     2679           
  Misses        209      209           
  Partials       28       28           
Impacted Files Coverage Ξ”
packages/design-tokens/utils/theme-prop-type.ts 0.00% <ΓΈ> (ΓΈ)

@connor-baer connor-baer merged commit e4c940b into main May 14, 2021
@connor-baer connor-baer deleted the bugfix/theme-prop-type branch May 14, 2021 08:09
@github-actions github-actions bot mentioned this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should πŸ—‚ design-tokens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants