[DSYS-317] Mark the legacy color tokens as deprecated #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 006a4a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 172 172
Lines 3567 3567
Branches 1198 1198
=======================================
Hits 3271 3271
- Misses 275 276 +1
+ Partials 21 20 -1
|
connor-baer
changed the title
connor-baer
commented
Mar 1, 2023
Co-authored-by: Connor Bär <[email protected]>
|
Note about versioning: we will only release a new minor of |
|
🎉
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-317.
Purpose
Mark legacy color tokens as deprecated. They are being replaced by semantic color tokens (#1880).
Approach and changes
This marks legacy tokens (from
@sumup/design-tokens) as deprecated in their TS definition.Definition of done
Unit and integration testsMeets minimum browser supportMeets accessibility requirements