Revert the Button's disabled state #2340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#2299 improved the behavior of disabled Buttons. The
disabled
attribute was replaced with thearia-disabled
attribute, which enabled the disabled element to receive focus and be perceived by screenreader users.This is a breaking change since it requires developers to update unit tests that were validating the Button's disabled state using Testing Library's
.toBeDisabled()
matcher.We'd like to roll out the new button design in a minor version, so we've decided to postpone this functional change until the next major.
The other potentially major changes were found to be non-breaking, so we're able to include them in a minor release.
Approach and changes
disabled
attribute andpointer-events: none
style to ButtonsDefinition of done