Revert "Revert the Button's disabled state (#2340)" #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3361c45.
🦋 Changeset detectedLatest commit: fb4c485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## canary #2351 +/- ##
==========================================
+ Coverage 96.95% 96.97% +0.01%
==========================================
Files 252 252
Lines 20277 20273 -4
Branches 1263 1263
==========================================
Hits 19660 19660
+ Misses 604 600 -4
Partials 13 13
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2340.
Purpose
After further testing, I've concluded that there are too many subtle breaking changes related to the button redesign. The only safe way to roll them out is to release a major version with a detailed migration guide.
This means we can re-include the changes to the button's disabled state.
Approach and changes
Definition of done