Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility of the ButtonGroup with the Modal component #2349

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Dec 18, 2023

Purpose

With the new container-based responsive styles, the ButtonGroup now uses a vertical layout inside the Modal component on wide viewports. This is not the intended behavior.

Approach and changes

  • Reduced the container width at which the ButtonGroup component switches to a horizontal layout to improve compatibility with the Modal component.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: aa75a1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 0:17am

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2349 (0bfc8fb) into canary (31b7b64) will not change coverage.
The diff coverage is n/a.

❗ Current head 0bfc8fb differs from pull request most recent head aa75a1d. Consider uploading reports for the commit aa75a1d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #2349   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         252      252           
  Lines       20277    20277           
  Branches     1263     1263           
=======================================
  Hits        19660    19660           
  Misses        604      604           
  Partials       13       13           

@connor-baer connor-baer marked this pull request as ready for review December 19, 2023 12:15
@connor-baer connor-baer requested a review from a team as a code owner December 19, 2023 12:15
@connor-baer connor-baer changed the title ButtonGroup fixes Improve compatibility of the ButtonGroup with the Modal component Dec 19, 2023
@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Dec 19, 2023
@connor-baer connor-baer merged commit dbceca6 into canary Dec 19, 2023
@connor-baer connor-baer deleted the fix/buttongroup-responsive branch December 19, 2023 12:20
@connor-baer connor-baer mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant