Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease viewport width at which the ButtonGroup wraps #2399

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jan 22, 2024

Fixes #2349.

Purpose

With the new container-based responsive styles, the ButtonGroup now uses a vertical layout inside the Modal component on wide viewports. This is not the intended behavior.

Approach and changes

  • Reduced the container width at which the ButtonGroup component switches to a horizontal layout to improve compatibility with the Modal component.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: 906e9d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 7:42pm

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61ab980) 96.75% compared to head (906e9d0) 96.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
+ Coverage   96.75%   96.77%   +0.01%     
==========================================
  Files         227      227              
  Lines       18857    18857              
  Branches     1174     1173       -1     
==========================================
+ Hits        18246    18248       +2     
+ Misses        598      596       -2     
  Partials       13       13              

see 1 file with indirect coverage changes

@connor-baer connor-baer marked this pull request as ready for review January 23, 2024 09:13
@connor-baer connor-baer requested a review from a team as a code owner January 23, 2024 09:13
@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jan 23, 2024
@connor-baer connor-baer merged commit d6511aa into main Jan 23, 2024
13 of 14 checks passed
@connor-baer connor-baer deleted the fix/buttongroup-breakpoint branch January 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant