Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tag color on iOS #2951

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Fix Tag color on iOS #2951

merged 4 commits into from
Feb 19, 2025

Conversation

connor-baer
Copy link
Member

Purpose

iOS Safari renders buttons without an explicit color as blue.

Approach and changes

  • Apply an explicit text color to the Tag component
  • Use the latest color token values for Storybook

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Feb 19, 2025
@connor-baer connor-baer requested a review from a team as a code owner February 19, 2025 20:12
@connor-baer connor-baer requested a review from sirineJ February 19, 2025 20:12
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: a3c1cb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup-oss/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Feb 19, 2025 8:16pm

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (5d14b10) to head (a3c1cb4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2951   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         228      228           
  Lines       13058    13058           
  Branches     1760     1760           
=======================================
  Hits        11440    11440           
  Misses       1561     1561           
  Partials       57       57           

@connor-baer connor-baer merged commit 0cc2af2 into main Feb 19, 2025
12 of 14 checks passed
@connor-baer connor-baer deleted the bugfix/tag-color-ios branch February 19, 2025 20:21
@connor-baer connor-baer mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant