Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tag color on iOS #2951

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Fix Tag color on iOS #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
418acf5
Fix Tag color on iOS
connor-baer Feb 19, 2025
40a052d
Fix Storybook preview
connor-baer Feb 19, 2025
4a92882
Use latest color tokens for Storybook
connor-baer Feb 19, 2025
a3c1cb4
Upgrade vulnerable dependencies
connor-baer Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-eels-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sumup-oss/circuit-ui": patch
---

Fixed the Tag component's text color on iOS.
8 changes: 2 additions & 6 deletions .storybook/components/Icons.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@
width: 100%;
height: var(--cui-spacings-kilo);
content: "";
background: linear-gradient(
rgb(255 255 255 / 100%),
rgb(255 255 255 / 66%),
rgb(255 255 255 / 0%)
);
background: linear-gradient(var(--cui-bg-normal), transparent);
}
}

Expand Down Expand Up @@ -86,9 +82,9 @@
.label {
display: block;
overflow: hidden;
text-overflow: ellipsis;
font-size: var(--cui-body-s-font-size);
line-height: var(--cui-body-s-line-height);
text-overflow: ellipsis;
white-space: nowrap;
}

Expand Down
3 changes: 2 additions & 1 deletion .storybook/manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import '@sumup-oss/design-tokens/dynamic.css';

import type { CSSProperties } from 'react';
// biome-ignore lint/correctness/noUnusedImports:
import React, { type CSSProperties } from 'react';
import { addons, types } from '@storybook/manager-api';

import { dark, light, listenToColorScheme } from './themes.js';
Expand Down
20 changes: 10 additions & 10 deletions .storybook/themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const light = create({
appBg: '#ffffff', // var(--cui-bg-normal)
appContentBg: '#ffffff', // var(--cui-bg-normal)
appPreviewBg: '#ffffff', // var(--cui-bg-normal)
appBorderColor: '#c2c9d1', // var(--cui-border-normal)
appBorderColor: '#aeb6be', // var(--cui-border-normal)
appBorderRadius: 0,

// Text colors
Expand All @@ -31,15 +31,15 @@ export const light = create({

// Toolbar default and active colors
barTextColor: '#6a737c', // var(--cui-fg-subtle)
barHoverColor: '#33373e', // var(--cui-fg-subtle-hovered)
barSelectedColor: '#0f131a', // var(--cui-fg-subtle-pressed)
barHoverColor: '#6a737c', // var(--cui-fg-subtle-hovered)
barSelectedColor: '#6a737c', // var(--cui-fg-subtle-pressed)
barBg: '#ffffff', // var(--cui-bg-normal)

// Form colors
buttonBg: '#f6f7f9', // var(--cui-bg-subtle)
buttonBorder: '#d6dbe1', // var(--cui-border-subtle)
buttonBg: '#f0f1f5', // var(--cui-bg-subtle)
buttonBorder: '#e3e7ec', // var(--cui-border-subtle)
inputBg: '#ffffff', // var(--cui-bg-normal)
inputBorder: '#c2c9d1', // var(--cui-border-normal)
inputBorder: '#aeb6be', // var(--cui-border-normal)
inputTextColor: '#0f131a', // var(--cui-fg-normal)
inputBorderRadius: 4, // var(--cui-border-radius-bit)
});
Expand All @@ -48,13 +48,13 @@ export const dark = create({
base: 'dark',
...brand,
brandImage: '/images/logo-name-dark.png',
colorPrimary: '#ffffff', // var(--cui-fg-accent)
colorPrimary: '#e1e7ef', // var(--cui-fg-accent)
colorSecondary: '#ffffff', // var(--cui-fg-normal)

// UI
appBg: '#0f131a', // var(--cui-bg-normal)
appContentBg: '#0f131a', // var(--cui-bg-normal)
appPreviewBg: '#0f131a', // var(--cui-bg-normal)
appBg: '#171d24', // var(--cui-bg-normal)
appContentBg: '#171d24', // var(--cui-bg-normal)
appPreviewBg: '#171d24', // var(--cui-bg-normal)
});

export const components = {
Expand Down
Loading
Loading