-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write generated types to __types directories #4705
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8d0d10f
import generated types from .d.ts file - fixes #4701
Rich-Harris b6a43f3
write types to __types directory
Rich-Harris 890208f
update test fixtures
Rich-Harris bc1b66a
update template
Rich-Harris 934241b
update docs
Rich-Harris a94e7ef
changesets
Rich-Harris fd54e56
Update .changeset/soft-months-fail.md
Rich-Harris 8543179
fix tests
Rich-Harris 5f526c2
Merge branch 'gh-4701' of github.com:sveltejs/kit into gh-4701
Rich-Harris 82d85b1
remove incorrect files
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'create-svelte': patch | ||
--- | ||
|
||
import generated types from `__types/index.d.ts` file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': patch | ||
--- | ||
|
||
[breaking] write generated types to `__types` directories |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
packages/create-svelte/templates/default/src/routes/todos/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/emitTypes-false/expected/Test2.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/emitTypes-false/src/lib/Test2.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/exports-merge/expected/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/exports-merge/src/lib/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/exports-replace/expected/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/exports-replace/src/lib/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/javascript/expected/Test2.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/javascript/expected/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/javascript/src/lib/Test2.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
8 changes: 4 additions & 4 deletions
8
packages/kit/src/packaging/test/fixtures/javascript/src/lib/internal/Test.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<script> | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
/** | ||
* @type {import('./foo').Foo} | ||
*/ | ||
export let foo; | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/kit/test/apps/basics/src/routes/load/set-cookie-fetch/a.json.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/kit/test/apps/basics/src/routes/load/set-cookie-fetch/b.json.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/kit/test/apps/basics/src/routes/routing/params-in-handle/[x].js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/kit/test/apps/basics/src/routes/routing/route-id/[x].svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/kit/test/prerendering/basics/src/routes/fetch-404.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These also seem unrelated, but possibly ok to keep because else prettier complains (?)