Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(site): hide the context menu when the user made a choice #85

Merged
merged 4 commits into from
Oct 8, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 7, 2019

Description, Motivation and Context

  • see title - should've been that way from the start

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2019

This pull request introduces 58 alerts when merging 6a177d5 into 4acbacf - view on LGTM.com

new alerts:

  • 58 for Unused variable, import, function or class

@sverweij
Copy link
Owner Author

sverweij commented Oct 7, 2019

fixing that lgtm thing in #86

@sverweij sverweij force-pushed the feature/auto-hide-context-menu branch from 6a177d5 to 4f32644 Compare October 8, 2019 18:08
@codeclimate
Copy link

codeclimate bot commented Oct 8, 2019

Code Climate has analyzed commit 4f32644 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 782c02e into develop Oct 8, 2019
@sverweij sverweij deleted the feature/auto-hide-context-menu branch October 8, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant