Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lgtm): configure lgtm so it doesn't look at generated code #86

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 7, 2019

Description

see title

Motivation and Context

Out of the box lgtm takes into account way too much. This PR attempts to configure it so it only looks at that what matters.

How Has This Been Tested?

  • By submitting a PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2019

Code Climate has analyzed commit 76e2588 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit c453c73 into develop Oct 8, 2019
@sverweij sverweij deleted the chore/configure-lgtm branch October 8, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant