This repository has been archived by the owner on Jul 25, 2018. It is now read-only.
Added confirmation dialogues for deletion process #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heydenreich
force-pushed
the
dev/deleteConfirmationDialogue_#156
branch
from
beeb534 to
24da009
Compare
|
Reviewed, rebased, tested. A question arises - see issue: Solution:
|
heydenreich
force-pushed
the
dev/deleteConfirmationDialogue_#156
branch
2 times, most recently
from
5e1dafb to
a310b1e
Compare
…eases, licenses, vendors, etc. closes #156 Conflicts: frontend/sw360-portlet/src/main/webapp/html/projects/view.jsp
…view page; show also number of linked releases in delte confirmation dialogue for components closes #156
* a component can only be deleted if it contains no releases * Frontend checks whether releases are present and disables delete function * backend checks again Conflicts: frontend/sw360-portlet/src/main/webapp/html/projects/view.jsp
heydenreich
force-pushed
the
dev/deleteConfirmationDialogue_#156
branch
from
a310b1e to
e03b228
Compare
|
reviewed commit 1 and 2: OK |
|
tested with the mock projects as well as own new entries. also tested with attachments and different numbers of attachments and links to see if counting works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before dev/projectExcelExport and dev/datePicker_#171 !
closes #156