This repository has been archived by the owner on Jul 25, 2018. It is now read-only.
increase lucene filter limit and avoid moderation request zombie #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heydenreich
added
needs code review
do not merge - нет!
and removed
needs code review
labels
|
@heydenreich: please rename the title |
heydenreich
changed the title
* get a maximum of 150 results when using the filter in project and component portlet * has to be tested: is speed still ok? * closes #221 if speed is ok
* if last moderator wants to unsubscribe, pop-up - not allowed * closes #114
…d in linkedProjects.jspf * changes for license info download also apply to project details view in moderation portlet * there, licenseDownloadInfo is not available and not necessary -> moderation portlet crashed * solution: make download license info form only available in project detail mode
heydenreich
force-pushed
the
dev/luceneFilterLimitAndModerationRequestZombie
branch
from
da02a79 to
27b9e69
Compare
|
|
tested the moderator thing with components, projects and releases -> OK |
|
tested the search limit -> works as well |
|
looked at the source code with my basic understanding, looks OK. |
maxhbr
reviewed
Sep 20, 2016
| } catch(TException e) { | ||
| log.error("Error in Moderation ", e); | ||
| } | ||
| request.setAttribute(PortalConstants.REQUEST_STATUS, status); |
There was a problem hiding this comment.
Would be good to move this into the try-block. One should not set an attribute to null
maxhbr
reviewed
Sep 20, 2016
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| import static com.siemens.sw360.datahandler.common.CommonUtils.addAll; | |||
| import static com.siemens.sw360.datahandler.common.CommonUtils.removeAll; | |||
| import static com.siemens.sw360.datahandler.common.CommonUtils.nullToEmptySet; | |||
|
|
||
|
|
||
| <%@include file="/html/moderation/includes/moderationActionButtons.jspf"%> | ||
| <br/> |
There was a problem hiding this comment.
This return looks like a hack to solve a css problem. Might be better to wrap the buttons into a div and use the display:... or margin:... properties
There was a problem hiding this comment.
There was a problem hiding this comment.
it is already wrapped in a div. I removed the <br/>
heydenreich
force-pushed
the
dev/luceneFilterLimitAndModerationRequestZombie
branch
from
f59b404 to
d703a80
Compare
heydenreich
force-pushed
the
dev/luceneFilterLimitAndModerationRequestZombie
branch
from
d703a80 to
d110b73
Compare
heydenreich
deleted the
dev/luceneFilterLimitAndModerationRequestZombie
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set lucene.limit to 150 …
avoid moderation request zombie …