Add i18n feature flag to ThemeSettings schema #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-kusters
approved these changes
Apr 18, 2023
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
Kyle-Ye
requested changes
Jul 7, 2023
| @@ -856,6 +856,9 @@ | |||
| }, | |||
| "onThisPageNavigator": { | |||
| "$ref": "#/components/schemas/FeatureFlagDisable" | |||
| }, | |||
| "i18n": { | |||
| "$ref": "#/components/schemas/FeatureFlagDisable" | |||
There was a problem hiding this comment.
i18 is defined by "enable"
Suggested change
| "$ref": "#/components/schemas/FeatureFlagDisable" | |
| "$ref": "#/components/schemas/FeatureFlagEnable" |
There was a problem hiding this comment.
|
@swift-ci please test |
|
@swift-ci please test |
|
@ethan-kusters can you take another look, please? Thanks |
Kyle-Ye
approved these changes
Jul 10, 2023
ethan-kusters
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Looks good! I'm wondering if we should consider using the full word "localization" "internationalization" to make this a little more accessible for people not familiar with the "i18n" abbreviation but I think that change is likely out-of-the-scope of this review so I'm happy to land this as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #102139999, if applicable:
Summary
This PR adds i18n feature flag to ThemeSettings JSON schema
Dependencies
swiftlang/swift-docc-render#523