Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n feature flag to ThemeSettings schema #475

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Add i18n feature flag to ThemeSettings schema #475

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30309f3
[rdar://102139999] feat: add i18n feature flag to schema
marinaaisa Feb 10, 2023
5d591a2
Merge branch 'main' into r102139999/hardcoded-strings-i18n
ethan-kusters Apr 18, 2023
c2b796f
Merge branch 'main' into r102139999/hardcoded-strings-i18n
marinaaisa Apr 20, 2023
8b24ccc
Merge branch 'main' into r102139999/hardcoded-strings-i18n
marinaaisa Apr 27, 2023
d2fba16
fix: FeatureFlagEnable instead of FeatureFlagDisable
marinaaisa Jul 10, 2023
7bbe05a
Merge branch 'main' into r102139999/hardcoded-strings-i18n
marinaaisa Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/SwiftDocC/SwiftDocC.docc/Resources/ThemeSettings.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,9 @@
},
"onThisPageNavigator": {
"$ref": "#/components/schemas/FeatureFlagDisable"
},
"i18n": {
ethan-kusters marked this conversation as resolved.
Show resolved Hide resolved
"$ref": "#/components/schemas/FeatureFlagDisable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18 is defined by "enable"

Suggested change
"$ref": "#/components/schemas/FeatureFlagDisable"
"$ref": "#/components/schemas/FeatureFlagEnable"

Copy link
Contributor

@Kyle-Ye Kyle-Ye Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/apple/swift-docc-render/blob/95129994a3e5e3ccb48ad8cd2ca4fd38f91e9afe/src/App.vue#L98 and https://github.com/apple/swift-docc/blob/d3239b1042430ac8eb1cc84cfc3c5cd17f505356/Sources/SwiftDocC/SwiftDocC.docc/Resources/ThemeSettings.spec.json#L907-L918

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it @Kyle-Ye ! I fixed it d2fba16

}
}
}
Expand Down