Add support to custom type hint #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndraGunawan
force-pushed
the
custom-typehint
branch
from
a036317 to
84d9920
Compare
IndraGunawan
force-pushed
the
custom-typehint
branch
from
31b9976 to
0f61865
Compare
IndraGunawan
changed the title
|
@weaverryan this PR was ready, i don't think the CI failure related to this PR, any suggestions? |
|
@jrushlow this PR is ready for review |
|
up. cool to merge |
jrushlow
requested changes
Sep 22, 2022
There was a problem hiding this comment.
Sorry for the delay @IndraGunawan - I didnt dig through this too deep as I believe there are quite a few changes that have taken place since you first created the PR. If you can rebase and get us green tests, ill get this reviewed && merged.. Thanks in advance!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1002