-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DoctrineHelper] handle property type for custom doctrine type #1413
Conversation
8f7fb20
to
2d97340
Compare
CI error is not related |
@jrushlow @weaverryan any chance to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. A couple minor comments to improve readability.
8821636
to
f213527
Compare
f213527
to
339202e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @IndraGunawan!
fixed: #1002
replace: #1021
sample custom type
this change will get
convertToPHPValue
function return type and set it as property typeif no return type defined on
convertToPHPValue
function then the property will not have any type hint