Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default value to mapped option of entity #3407

Closed
wants to merge 2 commits into from
Closed

add default value to mapped option of entity #3407

wants to merge 2 commits into from

Conversation

nykopol
Copy link
Contributor

@nykopol nykopol commented Jan 3, 2014

No description provided.

@wouterj
Copy link
Member

wouterj commented Jan 3, 2014

👍

weaverryan added a commit that referenced this pull request Jan 7, 2014
@weaverryan
[#3407] Re-wording things so that people don't pay too much attention…
3205bbd 
… to auto_initialize
@weaverryan
Copy link
Member

Nice work Johan!

I've patched this into the 2.3 branch at sha: d85a165 and sha: 976f61c. I re-worded it slightly, just so that people make sure to not think that this option is too important, since they won't need to change it - see sha: 3205bbd. If you see any issues, please let me know.

Thanks!

@weaverryan weaverryan closed this Jan 7, 2014
@wouterj
Copy link
Member

wouterj commented Jan 7, 2014

Actually, this needs more changes. Look at https://github.com/symfony/symfony-docs/pull/2397/files#diff-1710943091c45822b0185cbf74d5472cR42 from an example, @weaverryan can you do this or should I create a PR?

weaverryan added a commit that referenced this pull request Jan 9, 2014
@weaverryan
[#3407] Adding a missing section via tip from @wouterj
8f3e6c7
@weaverryan weaverryan mentioned this pull request Jan 9, 2014
Merged
@weaverryan
Copy link
Member

@wouterj I've got it fixed at #3448 - but don't hesitate to fix this in the future (or fix anything else you may see with this) :). I'm going to start making PR's a bit more often myself to go through the same workflow as everyone.

Thanks!

@weaverryan weaverryan mentioned this pull request Jan 9, 2014
Closed
weaverryan added a commit that referenced this pull request Jan 10, 2014
@weaverryan
bug #3448 Overridden tweak (weaverryan)
42c80d1 
This PR was merged into the 2.3 branch.

Discussion
----------

Overridden tweak

Hi guys!

Tiny change (so skipping the PR table) - see #3407 (comment)

Thanks!

Commits
-------

8f3e6c7 [#3407] Adding a missing section via tip from @wouterj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nykopol @wouterj @weaverryan