Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #3412 documenting overriden options #3417

Closed
wants to merge 8 commits into from

Conversation

nykopol
Copy link
Contributor

@nykopol nykopol commented Jan 3, 2014

Q A
Doc fix? no
New docs? yes
Applies to 2.3
Fixed tickets #3412

@weaverryan
Copy link
Member

@nykopol - this looks good. It'll need a rebase (it contains some duplicated changes from #3407) - but keep going! :)

@nykopol
Copy link
Contributor Author

nykopol commented Jan 9, 2014

@weaverryan yes it's my mistake i did not start in an other branch. When you say a 'rebase' you think a new PR ?

@weaverryan
Copy link
Member

Hey @nykopol!

No problem :). You can actually rebase your overridden_options branch and then force push right back to it. Assuming upstream is the remote name for symfony/symfony-docs and origin is to your fork, something like:

git checkout overridden_options
git fetch upstream
git rebase upstream/master
git push origin overridden_options --force

As soon as you push to the overridden_options branch on your fork, those commits will show up here. You'll need to fix some conflicts after running rebase.

Cheers!

@nykopol
Copy link
Contributor Author

nykopol commented Jan 12, 2014

Thanks @weaverryan for you help. I don't had conflict on rebase but on push. I hope it's ok now.

@wouterj
Copy link
Member

wouterj commented Jan 12, 2014

Sorry @nykopol it's still conflicting.

@weaverryan
Copy link
Member

Hey @nykopol!

Yea, it's still conflicting unfortunately :). Did you fetch from the "symfony/symfony-docs" repository and rebase against its master?

Let me know! Thanks!

@weaverryan
Copy link
Member

Hi guys!

I've rebased and re-opened this PR at #3506 for review. I'll close this :).

Thanks!

@weaverryan weaverryan closed this Jan 22, 2014
weaverryan added a commit that referenced this pull request Feb 3, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Nykopol overriden options

See #3417 - this is just a rebase to continue it :)

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3
| Fixed tickets | #3412

Thanks!

Commits
-------

e574e97 Removing an extra line thanks to @xabbuh
4f6cb9d Some additional tweaks and probably some merge conflict fixes
362c8b4 document overriden options of choice field
70feefd document overriden options of checkbox
c62cd13 correct overriden option of button and add checkbox overriden option
ab4aafe correct overriden option of button and add checkbox overriden option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants