acpi: Report RPM values instead of raw tachometer values #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpot51
previously approved these changes
May 2, 2024
crawfxrd
force-pushed
the
acpi-rpm
branch
2 times, most recently
from
85a28b3 to
cf0c2d2
Compare
jackpot51
previously approved these changes
May 17, 2024
jackpot51
previously approved these changes
Jun 17, 2024
Ref: IT5570E V0.3.2 datasheet; 7.12.3.2 Manual Fan Control Mode Signed-off-by: Tim Crawford <[email protected]>
|
Included in #474. |
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Jul 18, 2024
System76 EC since system76/ec#456 performs the RPM calculation itself and stores it in EC RAM where previously the raw tachometer values were saved. The SBIOS is no longer required to make the conversion. Ref: system76/ec#456 Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Jul 18, 2024
System76 EC since system76/ec@80cfa91b9fd5 ("acpi: Report RPM values instead of raw tachometer values") performs the RPM calculation itself and stores it in EC RAM where previously the raw tachometer values were saved. The SBIOS is no longer required to make the conversion. Ref: system76/ec#456 Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5 Signed-off-by: Tim Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the fan RPM values in the EC instead of coreboot ACPI, as it depends entirely on the EC configuration.
Requires: system76/coreboot#222