ec/system76/ec: Add config for 2nd fan without dGPU #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpot51
approved these changes
May 2, 2024
jackpot51
approved these changes
May 17, 2024
jackpot51
approved these changes
Jun 17, 2024
This calculation depends on the EC configuration. The EC is now responsible for the calculation, and the RAM values have the actual RPM values. Change-Id: Ifabbcb5922643e218ed7c4984b1d41aee841bb39 Signed-off-by: Tim Crawford <[email protected]>
The darp10 has a second fan but no dGPU. The NFAN Method must exist, so use the default hwmon names of "fan1" and "fan2" for labels. Change-Id: Icde5dec82262d9262b046c1557167801af8e5cb2 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
changed the title
This was referenced Jul 5, 2024
XV-02
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The darp10 has a second fan but no dGPU. The NFAN Method must exist, so use the default hwmon names of "fan1" and "fan2" for labels.
The RPM calculation depends on the EC configuration. The EC is now responsible for the calculation, and the RAM values have the actual RPM values.
Requires: system76/ec#474