Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for second fan without a dGPU #563

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add support for second fan without a dGPU #563

merged 1 commit into from
Jul 25, 2024

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Jul 5, 2024

Decouple the fan logic from the dGPU logic. Firmware now supports a second fan on systems without a dGPU, such as darp10.

Behavioral changes:

  • ectool: Fans are now indexed from 1 instead of 0
  • Linux: darp10 now reports details about the second fan

Requires:

@crawfxrd crawfxrd changed the title Add support for second fan without dGPU Add support for second fan without a dGPU Jul 5, 2024
Decouple the fan logic from the dGPU logic. Firmware now supports a
second fan on systems without a dGPU, such as darp10.

Behavioral changes:

- ectool: Fans are now indexed from 1 instead of 0
- Linux: darp10 now reports details about the second fan

Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd crawfxrd marked this pull request as ready for review July 18, 2024 01:57
@crawfxrd crawfxrd requested review from a team July 18, 2024 01:57
Copy link
Contributor

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was tested as part of testing it's constituent components. Darp10, Gaze16-3060-B, and Lemp13-B all behaved as expected. I see no reason not to merge this PR.

@crawfxrd crawfxrd merged commit 51f639a into master Jul 25, 2024
@crawfxrd crawfxrd deleted the fan2 branch July 25, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants