add message defaults to .ok() and .notOk()

[paulcpederson]

Just noticed in a reporter that there are really nice test defaults for methods like .equals, but .ok() and .notOk() just say (unnamed assert).

This adds the following default messages:

• .ok() - "should be truthy"
• .notOk() - "should be falsey"

Also updates the tests where they are expecting the old default value.

[ljharb]

nit: falsy shouldn't have an e imo.

[ljharb]

also i don't see any tests covering the falsy case

[paulcpederson]

@ljharb ok, updated to falsy. None of the tests threw an error when I changed the notOk error message. Does that mean there are currently no tests for notOk?

[ljharb]

@paulcpederson that's the conclusion i would also come to. would you mind adding some?

fwiw I really like this change - it doesn't change the API, just makes two of the assertions more useful by default.

[paulcpederson]

cool. I think I can figure out how to do that.

[paulcpederson]

@ljharb ok I added a new test that just tests all of the defaults. Sorry that took me a bit to figure out the test structure. Testing a testing framework is very meta.

[ljharb]

Awesome, this LGTM as a semver-minor change.

Any other collaborators object? If not, I'll merge this in a day or two.

[paulcpederson]

@ljharb bump.

Have any other collaborators taken a look?

[ljharb]

Thanks for the bump - I'll merge this today or tomorrow.

[ljharb]

@paulcpederson actually would you mind rebasing this on the latest master?

[paulcpederson]

Not at all.

[ljharb]

Thanks, ping me when it's updated and I'll merge it!

[paulcpederson]

@ljharb ok, should be rebased now from master thanks for your patience, things got a little crazy today!