Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[results] increase object-inspect depth for expected/actual #293

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

scottbessler
Copy link
Contributor

It may be best for this to be configurable, but for now 5 seems like
a default that is often too low resulting in confusing output that shows
expected/actual to be identical when the difference is >5 deep.

@ljharb
Copy link
Collaborator

ljharb commented Jun 13, 2016

I think if we're going to make a change like this, we might as well allow it to be configurable.

Personally I think 5 is way way too deep to avoid confusion, let alone 10 - so clearly that number is subjective.

Allow to configure objectPrintDepth to avoid confusing output that shows
expected/actual to be identical when the difference is >5 deep.
@scottbessler
Copy link
Contributor Author

I hear ya. Made it configurable via opts.objectPrintDepth

@ljharb
Copy link
Collaborator

ljharb commented Jun 16, 2016

This seems reasonable to me, thanks (it'll be a semver-minor).

I'll leave this here for a few more days before merging.

@ljharb ljharb merged commit a196915 into tape-testing:master Jun 20, 2016
ljharb added a commit that referenced this pull request Jun 20, 2016
 - [New] make object-inspect depth configurable for expected/actual (#293)
 - [New] add message defaults to .ok() and .notOk() (#261)
 - [Robustness] be robust against the global `setTimeout` changing (#292)
 - [Deps] update `glob`, `object-inspect`
 - [Dev Deps] update `js-yaml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants