Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Do away with IsPropertyKey AO. #3316

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Editorial: Do away with IsPropertyKey AO. #3316

merged 1 commit into from
Apr 25, 2024

Conversation

rkirsling
Copy link
Member

Per @michaelficarra's suggestion here, let's just replace the AO IsPropertyKey with the phrasing "is a property key", given that "property key" is a well-defined term.

@rkirsling rkirsling mentioned this pull request Apr 23, 2024
Merged
rkirsling added a commit to rkirsling/ecma262 that referenced this pull request Apr 23, 2024
@rkirsling
Update phrasing to match tc39#3316.
2382785
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Apr 23, 2024
jmdyck
jmdyck requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This un-defines sec-ispropertykey, which you might want to add as an oldid on the <dfn> for "property key".

jmdyck
jmdyck approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ljharb ljharb added editorial change editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Apr 23, 2024
syg
syg approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Apr 24, 2024
@bakkot bakkot added editor call to be discussed in the next editor call ready to merge Editors believe this PR needs no further reviews, and is ready to land. labels Apr 24, 2024
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Apr 24, 2024
@ljharb ljharb force-pushed the remove-ispropertykey-ao branch from a020e87 to 705742e Compare April 25, 2024 04:55
@ljharb ljharb merged commit 705742e into tc39:main Apr 25, 2024
7 checks passed
@rkirsling rkirsling deleted the remove-ispropertykey-ao branch May 15, 2024 02:05
@jmdyck jmdyck mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

@jmdyck jmdyck jmdyck approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkirsling @syg @michaelficarra @bakkot @jmdyck @ljharb