Editorial: Replace IsIntegralNumber AO with is an integral Number
#3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Jun 5, 2024
michaelficarra
added
the
ready to merge
…c39#3344) Also, add "finite" to the definition of "integral Number".
bakkot
added a commit
to bakkot/proposal-temporal
that referenced
this pull request
Sep 5, 2024
ptomato
pushed a commit
to tc39/proposal-temporal
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a
<dfn>for "integral Number" since PR #2007, and the status quo uses it about 80 times. So it's odd that we still have the AOIsIntegralNumber(which dates back to ES6 where it had the nameIsInteger).This PR replaces the few uses of
IsIntegralNumberwithis an integral Number.It also inserts the word "finite" into the definition of "integral Number", as noted by bakkot.
(Compare to PR #3316 replacing
IsPropertyKeywithis a property key.)