New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement arithmetic and rounding relative to ZonedDateTime #1171

Closed

4 tasks done

ptomato opened this issue Nov 10, 2020 · 0 comments · Fixed by #1185

Closed

4 tasks done

Implement arithmetic and rounding relative to ZonedDateTime #1171

ptomato opened this issue Nov 10, 2020 · 0 comments · Fixed by #1185

Assignees

Labels

non-prod-polyfill spec-text

Milestone

Stable proposal

Collaborator

ptomato commented Nov 10, 2020 •

edited

Loading

This is a separate issue that covers the last point in the checklists in #856 and #569, which are actually the same thing. I suspect that all the code for these is the same.

implement ZonedDateTime as relativeTo parameter in Duration.round() method
implement ZonedDateTime as relativeTo parameter in Duration.total() method
implement ZonedDateTime as relativeTo parameter in Duration.add() and subtract() methods
fix ZonedDateTime.round() case when rounding to the nearest day and that day is ≠24 hours long

ptomato added spec-text non-prod-polyfill labels

ptomato added this to the Stable proposal milestone

ptomato self-assigned this

This was referenced Nov 10, 2020

Consider alternatives to Temporal.DateTime (ZonedAbsolute) #569

Closed

Proposal: rounding and balancing for Duration type (replaces #789) #856

Closed

Misc fixes #1172

Merged

ptomato added a commit that referenced this issue


          Separate rounding out of DifferenceZonedDateTime

4b2e918

This splits the rounding operation out of DifferenceZonedDateTime. It
should be followed by RoundDuration and then by AdjustRoundedDurationDays
if necessary.

This also allows RoundDuration to take a ZonedDateTime as its relativeTo
parameter (though it doesn't work yet in all cases.)

AdjustRoundedDurationDays does a second round operation if the time part
of the duration has rounded up to exceed the day length. It should be
called after AdjustRoundedDurationDays if necessary. Sometimes it is not:
it's only needed if relativeTo is a ZonedDateTime, and it's not needed in
Duration.total() (because the fractional days returned would be the same
regardless.)

See: #1171

ptomato added a commit that referenced this issue


          Separate out NanosecondsToDays from DifferenceZonedDateTime

ee8d095

This new abstract operation will be used in more places when converting
nanoseconds to time-zone-aware days.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

768a17f

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato mentioned this issue

Misc ZonedDateTime and Duration changes to support relativeTo #1176

Merged

ptomato added a commit that referenced this issue


          Separate rounding out of DifferenceZonedDateTime

715c20b

This splits the rounding operation out of DifferenceZonedDateTime. It
should be followed by RoundDuration and then by AdjustRoundedDurationDays
if necessary.

This also allows RoundDuration to take a ZonedDateTime as its relativeTo
parameter (though it doesn't work yet in all cases.)

AdjustRoundedDurationDays does a second round operation if the time part
of the duration has rounded up to exceed the day length. It should be
called after AdjustRoundedDurationDays if necessary. Sometimes it is not:
it's only needed if relativeTo is a ZonedDateTime, and it's not needed in
Duration.total() (because the fractional days returned would be the same
regardless.)

See: #1171

ptomato added a commit that referenced this issue


          Separate out NanosecondsToDays from DifferenceZonedDateTime

2e202e4

This new abstract operation will be used in more places when converting
nanoseconds to time-zone-aware days.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

6e07e90

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato added a commit that referenced this issue


          Separate rounding out of DifferenceZonedDateTime

e677c6f

This splits the rounding operation out of DifferenceZonedDateTime. It
should be followed by RoundDuration and then by AdjustRoundedDurationDays
if necessary.

This also allows RoundDuration to take a ZonedDateTime as its relativeTo
parameter (though it doesn't work yet in all cases.)

AdjustRoundedDurationDays does a second round operation if the time part
of the duration has rounded up to exceed the day length. It should be
called after AdjustRoundedDurationDays if necessary. Sometimes it is not:
it's only needed if relativeTo is a ZonedDateTime, and it's not needed in
Duration.total() (because the fractional days returned would be the same
regardless.)

See: #1171

ptomato added a commit that referenced this issue


          Separate out NanosecondsToDays from DifferenceZonedDateTime

9a804fd

This new abstract operation will be used in more places when converting
nanoseconds to time-zone-aware days.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

1dc8575

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato added a commit that referenced this issue


          Separate out NanosecondsToDays from DifferenceZonedDateTime

d3f3d04

This new abstract operation will be used in more places when converting
nanoseconds to time-zone-aware days.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

08da34d

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato added a commit that referenced this issue


          Separate rounding out of DifferenceZonedDateTime

a744300

This splits the rounding operation out of DifferenceZonedDateTime. It
should be followed by RoundDuration and then by AdjustRoundedDurationDays
if necessary.

This also allows RoundDuration to take a ZonedDateTime as its relativeTo
parameter (though it doesn't work yet in all cases.)

AdjustRoundedDurationDays does a second round operation if the time part
of the duration has rounded up to exceed the day length. It should be
called after AdjustRoundedDurationDays if necessary. Sometimes it is not:
it's only needed if relativeTo is a ZonedDateTime, and it's not needed in
Duration.total() (because the fractional days returned would be the same
regardless.)

See: #1171

ptomato added a commit that referenced this issue


          Separate out NanosecondsToDays from DifferenceZonedDateTime

97d30d3

This new abstract operation will be used in more places when converting
nanoseconds to time-zone-aware days.

See: #1171

ptomato added a commit that referenced this issue


          Add skipped tests for more ZonedDateTime relativeTo functionality

59a6823

These tests don't work yet, but it's nonetheless good to have them
reviewed and landed in the test suite.

See: #1171

ptomato added a commit that referenced this issue


          Support ZonedDateTime relativeTo in Duration arithmetic

18bd55a

duration.add(other, { relativeTo }) is by definition equal to
relativeTo.until(relativeTo.add(duration).add(other)), so rewrite
AddDuration to work that way.

See: #1171

ptomato added a commit that referenced this issue


          Support non-24-hour days in ZonedDateTime rounding

013fc93

Adds a day length parameter to RoundDateTime and RoundTime in order to
take non-24-hour days into account when rounding a time to the nearest
day.

See: #1171

ptomato mentioned this issue

Some ZonedDateTime relativeTo support #1182

Merged

Ms2ger added a commit that referenced this issue


          Support non-24-hour days in ZonedDateTime rounding

8cf6f1d

Adds a day length parameter to RoundDateTime and RoundTime in order to
take non-24-hour days into account when rounding a time to the nearest
day.

See: #1171

Co-authored-by: Ms2ger <[email protected]>

Ms2ger pushed a commit that referenced this issue


          Support ZonedDateTime relativeTo in Duration arithmetic

36ecdc3

duration.add(other, { relativeTo }) is by definition equal to
relativeTo.until(relativeTo.add(duration).add(other)), so rewrite
AddDuration to work that way.

See: #1171

Ms2ger added a commit that referenced this issue


          Support non-24-hour days in ZonedDateTime rounding

0879a9f

Adds a day length parameter to RoundDateTime and RoundTime in order to
take non-24-hour days into account when rounding a time to the nearest
day.

See: #1171

Co-authored-by: Ms2ger <[email protected]>

ptomato added a commit that referenced this issue


          Return the length of the last day from NanosecondsToDays

4edb6b4

In case you need to round the remainder of nanoseconds to the nearest day,
you need to know how long the day is. This will be used to fix rounding
relative to a ZonedDateTime.

See: #1171

ptomato added a commit that referenced this issue


          Correctly round non-24-hour days in RoundDuration

ecea99d

When rounding or totaling time units, the length of the last day needs to
be taken into account if relativeTo is a ZonedDateTime. This fixes some of
the broken test cases.

See: #1171

ptomato added a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

348b214

When converting between days and lower units in BalanceDuration, we need
to take the offset shift into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account.

See: #1171

ptomato mentioned this issue

More relativeTo rounding #1185

Merged

ptomato added a commit that referenced this issue


          Return the length of the last day from NanosecondsToDays

597f457

In case you need to round the remainder of nanoseconds to the nearest day,
you need to know how long the day is. This will be used to fix rounding
relative to a ZonedDateTime.

See: #1171

ptomato added a commit that referenced this issue


          Correctly round non-24-hour days in RoundDuration

533187f

When rounding or totaling time units, the length of the last day needs to
be taken into account if relativeTo is a ZonedDateTime. This fixes some of
the broken test cases.

See: #1171

ptomato added a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

fece748

When converting between days and lower units in BalanceDuration, we need
to take the offset shift into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account.

See: #1171

ptomato added a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

9d7fdbd

When converting between days and lower units in BalanceDuration, we need
to take the exact time into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account.

See: #1171

ptomato added a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

6f811af

When converting between days and lower units in BalanceDuration, we need
to take the exact time into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account.

See: #1171

ptomato added a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

2e2d7d5

When converting between days and lower units in BalanceDuration, we need
to take the exact time into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account. As well, we need to take into account the possibility of
moving the time forward when adding, due to disambiguation.

These were handled correctly in DifferenceZonedDateTime but not in
NanosecondsToDays. In order to ensure that these algorithms don't diverge,
move all the important stuff from DifferenceZonedDateTime into
NanosecondsToDays, and use NanosecondsToDays in DifferenceZonedDateTime.

See: #1171

Ms2ger closed this as completed in #1185

Ms2ger pushed a commit that referenced this issue


          Return the length of the last day from NanosecondsToDays

In case you need to round the remainder of nanoseconds to the nearest day,
you need to know how long the day is. This will be used to fix rounding
relative to a ZonedDateTime.

See: #1171

Ms2ger pushed a commit that referenced this issue


          Correctly round non-24-hour days in RoundDuration

f2eb2f1

When rounding or totaling time units, the length of the last day needs to
be taken into account if relativeTo is a ZonedDateTime. This fixes some of
the broken test cases.

See: #1171

Ms2ger pushed a commit that referenced this issue


          Take non-24-hour days into account in BalanceDuration

c01f9b8

When converting between days and lower units in BalanceDuration, we need
to take the exact time into account, and likewise when converting
between lower units and days, we need to take the length of the last day
into account. As well, we need to take into account the possibility of
moving the time forward when adding, due to disambiguation.

These were handled correctly in DifferenceZonedDateTime but not in
NanosecondsToDays. In order to ensure that these algorithms don't diverge,
move all the important stuff from DifferenceZonedDateTime into
NanosecondsToDays, and use NanosecondsToDays in DifferenceZonedDateTime.

See: #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment