Misc fixes #1172
Merged
Misc fixes #1172
+90
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a straggler from the time calendar support (#522)
Suggested by Justin in code review, this makes sure the day header is printed even if midnight is skipped in a DST transition.
Now that relativeTo for DurationAdd has landed, we can use the simpler DurationAdd abstract operation here, instead of AdjustDayRelativeTo.
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 93.55% 90.67% -2.88%
==========================================
Files 19 17 -2
Lines 7961 8796 +835
Branches 1264 1251 -13
==========================================
+ Hits 7448 7976 +528
- Misses 506 808 +302
- Partials 7 12 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Missing argument.
Ms2ger
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on #1171