Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeMinuteNotValidDay incorrectly includes "60" #2238

Closed
anba opened this issue May 26, 2022 · 2 comments
Closed

TimeMinuteNotValidDay incorrectly includes "60" #2238

anba opened this issue May 26, 2022 · 2 comments
Assignees
@gibson042
Labels
iso8601-grammar ISO 8061 grammar normative Would be a normative change to the proposal spec-text Specification text involved
Milestone
Next batch of nor...

Comments

@anba
Copy link
Contributor

anba commented May 26, 2022

https://tc39.es/proposal-temporal/#prod-TimeMinuteNotValidDay includes 60, even though 60 isn't a valid minute amount.
anba added a commit to anba/proposal-temporal that referenced this issue Jun 9, 2022
@anba
Editorial: Remove "60" from TimeMinuteNotValidDay
01419a8 
This is probably non-normative, because "60" is already rejected in
`ParseISODateTime` when `IsValidTime` gets called.

Fixes tc39#2238
@anba anba mentioned this issue Jun 9, 2022
Closed
@ptomato ptomato added spec-text Specification text involved normative Would be a normative change to the proposal labels Jun 14, 2022
@ptomato
Copy link
Collaborator

ptomato commented Jul 5, 2022

Will be fixed by #2284.

@ptomato ptomato added the iso8601-grammar ISO 8061 grammar label Aug 11, 2022
@ptomato
Copy link
Collaborator

ptomato commented Aug 15, 2022

Closed by #2284.

@ptomato ptomato closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
iso8601-grammar ISO 8061 grammar normative Would be a normative change to the proposal spec-text Specification text involved
Projects
None yet
Milestone
Next batch of normative changes
Development

Successfully merging a pull request may close this issue.

Normative: Remove "60" from TimeMinuteNotValidDay anba/proposal-temporal
3 participants
@ptomato @gibson042 @anba