Normative: Remove "60" from TimeMinuteNotValidDay #2279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably non-normative, because "60" is already rejected in `ParseISODateTime` when `IsValidTime` gets called. Fixes tc39#2238
Codecov Report
@@ Coverage Diff @@
## main #2279 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 19 19
Lines 10528 10528
Branches 1699 1699
=======================================
Hits 9587 9587
Misses 929 929
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
gibson042
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
I think it is normative:
- Temporal.Calendar.from ( calendarLike ) calls ToTemporalCalendar(calendarLike).
- ToTemporalCalendar(temporalCalendarLike) with non-object temporalCalendarLike stringifies it to identifier and ParseTemporalCalendarString(identifier) if it does not identify a built-in calendar.
- ParseTemporalCalendarString ( isoString ) parses isoString as a |TemporalCalendarString| and returns the contained |CalendarName| as a string or "iso8601" if there is no |CalendarName|.
- |TemporalCalendarString| can expand to |CalendarTime|, which can expand to |TimeSpecWithOptionalTimeZoneNotAmbiguous|, which can expand to |TimeHourMinuteBasicFormatNotAmbiguous| |TimeZoneBracketedAnnotation|?, in which |TimeHourMinuteBasicFormatNotAmbiguous| can expand to |TimeHour| |TimeMinuteNotValidDay|.
So per current spec, Temporal.Calendar.from("0160") should return the built-in ISO 8601 calendar. But that is the very #2238 bug being fixed by this change.
ptomato
approved these changes
Jun 12, 2022
ptomato
changed the title
|
Subsumed by #2284. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably non-normative, because "60" is already rejected in
ParseISODateTimewhenIsValidTimegets called.Fixes #2238