Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define srpm_build_deps in the packit config #1760

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 13, 2022

Seems we need to define the srpm_build_deps key in the packit config to enable srpm building in copr. See the following two links to learn more about the change:

@psss psss added this to the 1.21 milestone Dec 13, 2022
@psss psss added the packaging Changes related to the rpm packaging label Dec 13, 2022
@psss
Copy link
Collaborator Author

psss commented Dec 13, 2022

/packit test

@psss
Copy link
Collaborator Author

psss commented Dec 13, 2022

@lachmanfrantisek, @jpopelka, @TomasTomecek, I'm trying to enable the srpm building in copr but ran into this:

Submit of the build failed: Cmd('git') failed due to: exit code(128) cmdline:
git fetch -v origin +refs/pull/1760/head:refs/remotes/origin/pr-changes/1760 stderr:
'fatal: couldn't find remote ref refs/pull/1760/head' 

Could this be caused by enable_net: False? Or is this something else?

@jpopelka
Copy link
Contributor

jpopelka commented Dec 14, 2022

@psss I can see 40 such events (from other projects) in Sentry from 4-7 pm yesterday, so there was probably some outage. Can you try again now?

@psss
Copy link
Collaborator Author

psss commented Dec 14, 2022

/packit test

@psss psss force-pushed the psss-packit-srpm-build-deps branch from 3ca16e5 to 1d3a8e6 Compare December 14, 2022 09:17
@psss
Copy link
Collaborator Author

psss commented Dec 14, 2022

@jpopelka
Copy link
Contributor

The last links brings me to packit/teemtee-tmt-1760-internal-wow, is that expected?

not able to answer, @lbarcziova perhaps? ^

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Seems we need to define the `srpm_build_deps` key in the `packit`
config to enable srpm building in copr. See the following two
links to learn more about the change:

    https://packit.dev/docs/configuration/#srpm_build_deps
    https://packit.dev/posts/copr-srpms/#deployment-phases
@psss psss force-pushed the psss-packit-srpm-build-deps branch from 1d3a8e6 to 8969951 Compare December 14, 2022 11:50
@psss psss merged commit 8969951 into main Dec 14, 2022
@psss psss deleted the psss-packit-srpm-build-deps branch December 14, 2022 11:50
@psss psss self-assigned this Dec 14, 2022
@lachmanfrantisek
Copy link
Contributor

The last links brings me to packit/teemtee-tmt-1760-internal-wow, is that expected?

@psss Yes, it's correct. The name should look like packit/{namespace}-{repository}-{PR-number} or packit/{namespace}-{repository}-{PR-number}-{identifier} if identifier is set.

It's for this job definition:

- job: tests
  trigger: pull_request
  identifier: "internal-wow"
  targets:
  - fedora-latest-stable
  use_internal_tf: True

So yes, I would say it's correct. The identifier is used in the status names as well:
Screenshot from 2022-12-15 11-30-22

@psss
Copy link
Collaborator Author

psss commented Dec 15, 2022

So yes, I would say it's correct. The identifier is used in the status names as well:

The thing is that the identifier is set for another job:

The links lead to:

But from here Details point to the same url:

I'd expect to be able to get the to srpm build logs of each of the tmt jobs:

@lachmanfrantisek, what do you think?

@lachmanfrantisek
Copy link
Contributor

@psss Aha, you are right.

The question is if it should do a single build and share it or run three Copr builds. Now the dashboard shows what actually happened ... this one uses the packit/teemtee-tmt-1760-internal-wow Copr repo.

It's yet another issue with the implicit Copr build for tests and identifiers and this should be fixed by packit/packit-service#1775 and packit/packit-service#1720

Is this ok for you that it works like that? (Before we fix those two issues.)

@lbarcziova
Copy link
Contributor

lbarcziova commented Jan 3, 2023

@psss, as Franta pointed out, this is a bug because of the implicit Copr builds for tests.

Would adding the explicit Copr build definition to your config:

- job: copr_build
  trigger: pull_request
  targets:
  - fedora-all
  - epel-8
  - epel-9
  enable_net: False

work for you? The build would be then run only once and reused by all test jobs. (With the issues linked by Franta, we are going that direction anyways)

lbarcziova added a commit to lbarcziova/tmt that referenced this pull request Jan 12, 2023
As described in teemtee#1760 (comment),
Packit is planning to require explicit build job definition for the testing jobs
(see packit/packit-service#1775).
Adding the explicit Copr build job should also prevent the current bug in Packit
related to usage of implicit build job and usage of identifiers.
lbarcziova added a commit to lbarcziova/tmt that referenced this pull request Jan 13, 2023
As described in teemtee#1760 (comment),
Packit is planning to require explicit build job definition for the testing jobs
(see packit/packit-service#1775).
Adding the explicit Copr build job should also prevent the current bug in Packit
related to usage of implicit build job and usage of identifiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Changes related to the rpm packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants