-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define srpm_build_deps
in the packit config
#1760
Conversation
/packit test |
@lachmanfrantisek, @jpopelka, @TomasTomecek, I'm trying to enable the srpm building in copr but ran into this:
Could this be caused by |
@psss I can see 40 such events (from other projects) in Sentry from 4-7 pm yesterday, so there was probably some outage. Can you try again now? |
/packit test |
3ca16e5
to
1d3a8e6
Compare
@jpopelka, thanks, looks good now. Trying to look at the logs, I follow the
The last links brings me to |
not able to answer, @lbarcziova perhaps? ^ |
Seems we need to define the `srpm_build_deps` key in the `packit` config to enable srpm building in copr. See the following two links to learn more about the change: https://packit.dev/docs/configuration/#srpm_build_deps https://packit.dev/posts/copr-srpms/#deployment-phases
1d3a8e6
to
8969951
Compare
@psss Yes, it's correct. The name should look like It's for this job definition:
So yes, I would say it's correct. The identifier is used in the status names as well: |
The thing is that the
The links lead to:
But from here I'd expect to be able to get the to srpm build logs of each of the tmt jobs:
@lachmanfrantisek, what do you think? |
@psss Aha, you are right. The question is if it should do a single build and share it or run three Copr builds. Now the dashboard shows what actually happened ... this one uses the It's yet another issue with the implicit Copr build for tests and identifiers and this should be fixed by packit/packit-service#1775 and packit/packit-service#1720 Is this ok for you that it works like that? (Before we fix those two issues.) |
@psss, as Franta pointed out, this is a bug because of the implicit Copr builds for tests. Would adding the explicit Copr build definition to your config: - job: copr_build
trigger: pull_request
targets:
- fedora-all
- epel-8
- epel-9
enable_net: False work for you? The build would be then run only once and reused by all test jobs. (With the issues linked by Franta, we are going that direction anyways) |
As described in teemtee#1760 (comment), Packit is planning to require explicit build job definition for the testing jobs (see packit/packit-service#1775). Adding the explicit Copr build job should also prevent the current bug in Packit related to usage of implicit build job and usage of identifiers.
As described in teemtee#1760 (comment), Packit is planning to require explicit build job definition for the testing jobs (see packit/packit-service#1775). Adding the explicit Copr build job should also prevent the current bug in Packit related to usage of implicit build job and usage of identifiers.
Seems we need to define the
srpm_build_deps
key in thepackit
config to enable srpm building incopr
. See the following two links to learn more about the change: