Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define pull request Copr build job in Packit config #1789

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

lbarcziova
Copy link
Contributor

Hi! As described in #1760 (comment), Packit is planning to require explicit build job definition for the testing jobs (see packit/packit-service#1775). Adding the explicit Copr build job should also prevent the current bug in Packit related to the usage of implicit build job + identifiers, which was brought up in the linked PR.

As described in teemtee#1760 (comment),
Packit is planning to require explicit build job definition for the testing jobs
(see packit/packit-service#1775).
Adding the explicit Copr build job should also prevent the current bug in Packit
related to usage of implicit build job and usage of identifiers.
@lbarcziova lbarcziova force-pushed the packit-config-pr-build-job branch from 4400305 to 4b7dd3c Compare January 13, 2023 10:56
@psss
Copy link
Collaborator

psss commented Jan 13, 2023

Thanks for preparing the config adjustment. So this means that we will see twice as many results in the testing overview, right? One for rpm-build and one for testing-farm. I'd say it's ok although the concise overview was perhaps a little bit better. @lukaszachy, @happz, @thrix, any thoughts here?

@psss psss added the command | tests tmt tests command label Jan 13, 2023
@psss psss added this to the 1.21 milestone Jan 13, 2023
@lbarcziova
Copy link
Contributor Author

So this means that we will see twice as many results in the testing overview, right? One for rpm-build and one for testing-farm.

You will see the rpm-build statuses as well, that's right.

The reason for the change is that we have implemented another feature where the build is a prerequisite for another job + the functionality regarding tests is still growing (identifiers, targets mapping, skipping the build), and this will make maintaining the code much easier for us.

@psss psss self-assigned this Jan 16, 2023
@psss
Copy link
Collaborator

psss commented Jan 16, 2023

Understood. Thanks for clarification.

@psss psss added the packaging Changes related to the rpm packaging label Jan 16, 2023
@psss psss merged commit 4b7dd3c into teemtee:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command | tests tmt tests command packaging Changes related to the rpm packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants