-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task for creating GitHub deployments #258
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @jace-ys. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a couple of things I'm uncertain about and would appreciate some feedback!
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/ok-to-test |
|
/retest |
@jace-ys switched the base branch to master as it got merged with |
Also if you could add the task with all the files in the task directory
Please see : #389 |
Thanks @sm43 for the heads-up. I have done this now and rebased again latest master 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small fix otherwise looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @chmouel
This PR looks good to me could you please have a look at it for once 😅 and merge this
task/github-create-deployment/0.1/github-create-deployment.yaml
Outdated
Show resolved
Hide resolved
task/github-create-deployment/0.1/github-create-deployment.yaml
Outdated
Show resolved
Hide resolved
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Sorry for the delay with fixing up this PR! Totally forgot this was still lingering about. /remove-lifecycle stale |
name: github | ||
key: token | ||
|
||
image: registry.access.redhat.com/ubi8/ubi:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: registry.access.redhat.com/ubi8/ubi:latest | |
image: registry.access.redhat.com/ubi8/ubi:8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the other github tasks still use latest
but I guess that they should all be pinned as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a PR #519 which will pin the version of all the tasks :)
task/github-create-deployment/0.1/github-create-deployment.yaml
Outdated
Show resolved
Hide resolved
Hi @vinamra28 and @divyansh42, Thanks for your feedback! I have taken them into account and adjusted the PR accordingly. Let me know what you think 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/cc @chmouel
task/github-create-deployment/0.1/github-create-deployment.yaml
Outdated
Show resolved
Hide resolved
This introduces a Task for creating GitHub deployments for a given repository. This allows people who rely on GitHub deployment events for their CD systems to be able create them from within a Tekton pipeline. This task is pretty much just a wrapper around the GitHub API for creating deployments. The main params required are the ref and environment for the deployment, and we fall back to the API's defaults for the other params.
/cc @chmouel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
thanks all 🙌 |
Changes
This introduces a Task for creating GitHub deployments for a given
repository. This allows people who rely on GitHub deployment events
for their CD systems to be able create them from within a Tekton
pipeline.
This task is pretty much just a wrapper around the GitHub API for
creating deployments. The main params required are the ref
and environment for the deployment, and we fall back to the API's
defaults for the other params.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.