Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task for creating GitHub deployments #258

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Task for creating GitHub deployments #258

merged 1 commit into from
Feb 3, 2021

Conversation

jace-ys
Copy link
Contributor

@jace-ys jace-ys commented Apr 6, 2020

Changes

This introduces a Task for creating GitHub deployments for a given
repository. This allows people who rely on GitHub deployment events
for their CD systems to be able create them from within a Tekton
pipeline.

This task is pretty much just a wrapper around the GitHub API for
creating deployments. The main params required are the ref
and environment for the deployment, and we fall back to the API's
defaults for the other params.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 6, 2020
@tekton-robot
Copy link

Hi @jace-ys. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2020
Copy link
Contributor Author

@jace-ys jace-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of things I'm uncertain about and would appreciate some feedback!

github/README.md Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
@jace-ys
Copy link
Contributor Author

jace-ys commented Apr 6, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: yes CLA has been signed label Apr 10, 2020
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 22, 2020

CLA Check
The committers are authorized under a signed CLA.

github/create_deployment.yaml Outdated Show resolved Hide resolved
github/create_deployment.yaml Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@jace-ys
Copy link
Contributor Author

jace-ys commented Apr 22, 2020

/retest

@vdemeester vdemeester changed the base branch from v1beta1 to master June 19, 2020 14:17
@vdemeester
Copy link
Member

@jace-ys switched the base branch to master as it got merged with v1beta1 now 👼

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2020
github/create_deployment.yaml Outdated Show resolved Hide resolved
@sm43
Copy link
Member

sm43 commented Jul 15, 2020

Also if you could add the task with all the files in the task directory

  ./task/         👈 the kind of the resource 
      /argocd       👈 definition file must have same name
        /0.1
          /README.md     👈 [optional] since there can be a fallback
          /argocd.yaml   👈 the file name must be resource name
        /0.2/...
      /golang-build
        /0.1
          /README.md
          /golang-build.yaml

Please see : #389
Let me know if you need help.

@jace-ys
Copy link
Contributor Author

jace-ys commented Jul 15, 2020

Thanks @sm43 for the heads-up. I have done this now and rebased again latest master 🙂

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2020
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small fix otherwise looks good to me

task/github-create-deployment/0.1/README.md Outdated Show resolved Hide resolved
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @chmouel
This PR looks good to me could you please have a look at it for once 😅 and merge this

@tekton-robot tekton-robot requested a review from chmouel July 23, 2020 15:36
@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
@jace-ys jace-ys requested a review from chmouel October 22, 2020 14:23
@jace-ys
Copy link
Contributor Author

jace-ys commented Oct 22, 2020

Sorry for the delay with fixing up this PR! Totally forgot this was still lingering about.

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
task/github-create-deployment/0.1/README.md Outdated Show resolved Hide resolved
task/github-create-deployment/0.1/README.md Outdated Show resolved Hide resolved
name: github
key: token

image: registry.access.redhat.com/ubi8/ubi:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: registry.access.redhat.com/ubi8/ubi:latest
image: registry.access.redhat.com/ubi8/ubi:8.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the other github tasks still use latest but I guess that they should all be pinned as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PR #519 which will pin the version of all the tasks :)

@jace-ys
Copy link
Contributor Author

jace-ys commented Oct 22, 2020

Hi @vinamra28 and @divyansh42,

Thanks for your feedback! I have taken them into account and adjusted the PR accordingly.

Let me know what you think 😄

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
/cc @chmouel

@jace-ys jace-ys requested a review from chmouel November 9, 2020 12:08
This introduces a Task for creating GitHub deployments for a given
repository. This allows people who rely on GitHub deployment events
for their CD systems to be able create them from within a Tekton
pipeline.

This task is pretty much just a wrapper around the GitHub API for
creating deployments. The main params required are the ref
and environment for the deployment, and we fall back to the API's
defaults for the other params.
@vinamra28
Copy link
Member

/cc @chmouel

@chmouel
Copy link
Member

chmouel commented Feb 3, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@vinamra28
Copy link
Member

/lgtm

@jace-ys
Copy link
Contributor Author

jace-ys commented Feb 3, 2021

thanks all 🙌

@tekton-robot tekton-robot merged commit dcaa00d into tektoncd:master Feb 3, 2021
@jace-ys jace-ys deleted the github-create-deployment branch February 8, 2021 10:59
@jace-ys jace-ys restored the github-create-deployment branch February 8, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes CLA has been signed lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants